Added a new keyboard: the Dumbo #9656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
reviewed
Jul 24, 2020
fauxpark
requested changes
Jul 29, 2020
noroadsleft
requested changes
Jul 30, 2020
Committed all of the suggested changes except for removing the bootloader reference comments in rules.mk as i think it is handy. Co-authored-by: Ryan <[email protected]> Co-authored-by: James Young <[email protected]>
Removed the bootloader reference as suggested Co-authored-by: Ryan <[email protected]>
drashna
approved these changes
Aug 4, 2020
fauxpark
requested changes
Aug 4, 2020
noroadsleft
reviewed
Aug 4, 2020
Co-authored-by: Ryan <[email protected]>
|
Do i need to take action in regards to the failed "PR Lint keyboards" check? And if so what needs to be done? |
|
The failure is for another board that isn't touched in this PR, you can safely ignore it. |
noroadsleft
requested changes
Aug 7, 2020
…_SPLIT_3x6_4 in the future_4 Co-authored-by: James Young <[email protected]>
|
Thanks! |
fdawans
pushed a commit
to fdawans/qmk_firmware
that referenced
this pull request
Aug 11, 2020
* added dumbo keyboard * added my personal keymap * changed picture in readme * removed rev1 folder to reduce clutter and confusion * missed a few changes in last commit, everything should be added now * Apply suggestions from code review Committed all of the suggested changes except for removing the bootloader reference comments in rules.mk as i think it is handy. * Update keyboards/dumbo/rules.mk Removed the bootloader reference as suggested * Apply clean up of info.json * Apply suggestions from noroadsleft to support community layout LAYOUT_SPLIT_3x6_4 in the future_4
fdawans
added a commit
to fdawans/qmk_firmware
that referenced
this pull request
Aug 11, 2020
This reverts commit b67f02f.
nicocesar
pushed a commit
to nicocesar/qmk_firmware
that referenced
this pull request
Aug 12, 2020
* added dumbo keyboard * added my personal keymap * changed picture in readme * removed rev1 folder to reduce clutter and confusion * missed a few changes in last commit, everything should be added now * Apply suggestions from code review Committed all of the suggested changes except for removing the bootloader reference comments in rules.mk as i think it is handy. * Update keyboards/dumbo/rules.mk Removed the bootloader reference as suggested * Apply clean up of info.json * Apply suggestions from noroadsleft to support community layout LAYOUT_SPLIT_3x6_4 in the future_4
fcoury
pushed a commit
to fcoury/qmk_firmware_archive
that referenced
this pull request
Sep 20, 2020
* added dumbo keyboard * added my personal keymap * changed picture in readme * removed rev1 folder to reduce clutter and confusion * missed a few changes in last commit, everything should be added now * Apply suggestions from code review Committed all of the suggested changes except for removing the bootloader reference comments in rules.mk as i think it is handy. * Update keyboards/dumbo/rules.mk Removed the bootloader reference as suggested * Apply clean up of info.json * Apply suggestions from noroadsleft to support community layout LAYOUT_SPLIT_3x6_4 in the future_4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a new folder in the keyboards folder called "Dumbo" with all of the neccesary subfolders and files, including a default keymap and my personal keymap. Both have been tested with the latest version of qmk and work without any issues.
Types of Changes
Issues Fixed or Closed by This PR
Checklist